Skip to content

Implement Resource Based Throttling on Querier#7442

Open
eeldaly wants to merge 7 commits intocortexproject:masterfrom
eeldaly:query-rbt
Open

Implement Resource Based Throttling on Querier#7442
eeldaly wants to merge 7 commits intocortexproject:masterfrom
eeldaly:query-rbt

Conversation

@eeldaly
Copy link
Copy Markdown
Contributor

@eeldaly eeldaly commented Apr 20, 2026

What this PR does: This PR implements the already built resource based throttling (#6674) to querier pods to allow for query rejection based on resource utilization.

Query Protection flags are the same as current with querier prefix:
-querier.query-protection.rejection.threshold.cpu-utilization=0.5 (0-1) (0 default)
-querier.query-protection.rejection.threshold.heap-utilization=0.5 (0-1) (0 default)

Metric for rejected queries cortex_querier_rejected_requests_total:
image

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
  • docs/configuration/v1-guarantees.md updated if this PR introduces experimental flags

Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
eeldaly added 2 commits April 20, 2026 16:05
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
Copy link
Copy Markdown
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
We probably need a cortex_querier_rejected_requests_total metric. right?

Comment thread docs/blocks-storage/querier.md Outdated
Comment thread docs/configuration/config-file-reference.md Outdated
Comment thread schemas/cortex-config-schema.json Outdated
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
eeldaly added 2 commits April 27, 2026 15:18
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
@eeldaly eeldaly requested a review from friedrichg April 27, 2026 22:32
Copy link
Copy Markdown
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2026
Signed-off-by: Essam Eldaly <60357054+eeldaly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/querier lgtm This PR has been approved by a maintainer size/L type/feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants